Update NouisliderProps.tooltips typing to match noUiSlider docs #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update changes the typings for
NouisliderProps.tooltips
to match the noUiSlider docs. I have tested these typings againstnouislider-react ^3.3.5
to ensure they pass TSlint checks and that there are no compile-time or run-time errors. I tested theFormatter
type usingwnumb ^1.2.0
as well as a custom function that returnedto
andfrom
methods.I realized after submitting the initial pull request that the types in
index.js
needed to be updated as well as the github.io page. I've updated those files as well and ranyarn test
, which passed all tests.